Hello,

I've sent a different patch fixing this same issue at "[FFmpeg-devel] [PATCH] 
avcodec/h2645_sei: allow building h2645_sei without".

Instead of adding an extra file to the build, it seems that a ifdef config was 
missing. There are other calls to ff_aom that are guarded by a similar ifdef in 
the same file.

> On 12 May 2025, at 08:49, Sebastian Koerner 
> <seb_koerner-at-hotmail....@ffmpeg.org> wrote:
> 
> Correction: Sorry, the log is from arm64, but the text says x86. It happens 
> to many non-linux platforms.
> 
> Also note that Hunk #1 of the patch is obviously junk.
> Should be just the one dependency to aom_film_grain.o
> 
> --- ffmpeg-7.1.1/libavcodec/Makefile.org        2025-05-12 11:48:13.000000000 
> +0200
> +++ ffmpeg-7.1.1/libavcodec/Makefile    2025-05-12 11:48:58.000000000 +0200
> @@ -108,7 +108,7 @@
>                                           h2645data.o h2645_parse.o 
> h2645_vui.o
> OBJS-$(CONFIG_H264PRED)                += h264pred.o
> OBJS-$(CONFIG_H264QPEL)                += h264qpel.o
> -OBJS-$(CONFIG_H264_SEI)                += h264_sei.o h2645_sei.o
> +OBJS-$(CONFIG_H264_SEI)                += h264_sei.o h2645_sei.o 
> aom_film_grain.o
> OBJS-$(CONFIG_HEVCPARSE)               += h2645data.o h2645_parse.o 
> h2645_vui.o
> OBJS-$(CONFIG_HEVC_SEI)                += h2645_sei.o aom_film_grain.o \
>                                           dynamic_hdr_vivid.o
> 
> 
> ________________________________
> From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> on behalf of Sebastian 
> Koerner <seb_koerner-at-hotmail....@ffmpeg.org>
> Sent: Monday, May 12, 2025 1:41 PM
> To: ffmpeg-devel@ffmpeg.org <ffmpeg-devel@ffmpeg.org>
> Subject: [FFmpeg-devel] [Patch] Linker error for 
> __ff_aom_uninit_film_grain_params
> 
> Summary of the bug:
> 
> When building ffmpeg 7.1.1 from source on macosx x86-64 and selecting only 
> h264 one can observe a linker error around __ff_aop_uninit_film_grain_params
> 
> 
> Undefined symbols for architecture arm64:
>  "_ff_aom_uninit_film_grain_params", referenced from:
>      _ff_h2645_sei_reset in h2645_sei.o
> ld: symbol(s) not found for architecture arm64
> 
> How to reproduce:
> 
> configure ffmpeg 7.1.1 for H.264 only, like
> 
> --enable-shared --disable-static   --disable-programs --disable-doc 
> --disable-everything --enable-decoder=h264 --enable-parser=h264 
> --disable-bzlib --disable-iconv --disable-lzma --disable-xlib --disable-zlib 
> --disable-libxcb --disable-vaapi
> 
> 
> Patch
> 
> --- ffmpeg-7.1.1/libavcodec/Makefile.org        2025-05-12 11:48:13.000000000 
> +0200
> +++ ffmpeg-7.1.1/libavcodec/Makefile    2025-05-12 11:48:58.000000000 +0200
> @@ -1,5 +1,5 @@
> NAME = avcodec
> -DESC = FFmpeg codec library
> +DESC = FFmpeg codec libriary
> 
> HEADERS = ac3_parser.h                                                  \
>           adts_parser.h                                                 \
> @@ -108,7 +108,7 @@
>                                           h2645data.o h2645_parse.o 
> h2645_vui.o
> OBJS-$(CONFIG_H264PRED)                += h264pred.o
> OBJS-$(CONFIG_H264QPEL)                += h264qpel.o
> -OBJS-$(CONFIG_H264_SEI)                += h264_sei.o h2645_sei.o
> +OBJS-$(CONFIG_H264_SEI)                += h264_sei.o h2645_sei.o 
> aom_film_grain.o
> OBJS-$(CONFIG_HEVCPARSE)               += h2645data.o h2645_parse.o 
> h2645_vui.o
> OBJS-$(CONFIG_HEVC_SEI)                += h2645_sei.o aom_film_grain.o \
>                                           dynamic_hdr_vivid.o
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to