On Fri, May 09, 2025 at 01:54:22PM +0200, Marton Balint wrote:
>
>
> On Fri, 9 May 2025, Michael Niedermayer wrote:
>
> > On Fri, May 09, 2025 at 12:28:00AM +0200, Marton Balint wrote:
> > > Codec probing was primarily added to the wav demuxer to support DTS-in-wav
> > > files, but DTS probing functions return AVPROBE_SCORE_EXTENSION+1, so we
> > > can be
> > > a bit more strict with the required score.
> > >
> > > This fixes MP3 misdetections for some wav files.
> > >
> > > Fixes ticket #11581.
> > >
> > > Signed-off-by: Marton Balint <c...@passwd.hu>
> > > ---
> > > libavformat/wavdec.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
> > > index dc7e49abc4..c65e0a2723 100644
> > > --- a/libavformat/wavdec.c
> > > +++ b/libavformat/wavdec.c
> > > @@ -178,7 +178,7 @@ static void handle_stream_probing(AVStream *st)
> > > {
> > > if (st->codecpar->codec_id == AV_CODEC_ID_PCM_S16LE) {
> > > FFStream *const sti = ffstream(st);
> > > - sti->request_probe = AVPROBE_SCORE_EXTENSION;
> > > + sti->request_probe = AVPROBE_SCORE_EXTENSION + 1;
> > > sti->probe_packets = FFMIN(sti->probe_packets, 32);
> > > }
> > > }
> >
> > please add a testcase to fate, if possible. Such corner cases
> > are important to be in fate
>
> Sample is in the ticket, so it should be pretty trivial to do so. Can't we> fund someone to do this and the other fixed trac tickets without fate tests? Iam in favor of funding that see https://trac.ffmpeg.org/wiki/SponsoringPrograms/STF/2025 thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become a president and 2 times more likely to become an astronaut, than to die in a terrorist attack." -- Thoughty2
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
