> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of
> softworkz .
> Sent: Mittwoch, 16. April 2025 13:33
> To: FFmpeg development discussions and patches <ffmpeg-
> de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2 02/10] fftools/textformat:
> Quality improvements
>
>
>
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of
> > Andreas Rheinhardt
> > Sent: Mittwoch, 16. April 2025 12:49
> > To: ffmpeg-devel@ffmpeg.org
> > Subject: Re: [FFmpeg-devel] [PATCH v2 02/10] fftools/textformat:
> > Quality improvements
> >
> > softworkz:
> > > From: softworkz <softwo...@hotmail.com>
> > >
> > > Signed-off-by: softworkz <softwo...@hotmail.com>
> > > ---
> > > fftools/textformat/avtextformat.c | 111 +++++++++++++++++++------
[..]
> > >
> > > #include "avtextformat.h"
> > > diff --git a/fftools/textformat/tw_avio.c
> > b/fftools/textformat/tw_avio.c
> > > index 6034f74ec9..b1743fb43a 100644
> > > --- a/fftools/textformat/tw_avio.c
> > > +++ b/fftools/textformat/tw_avio.c
> > > @@ -53,7 +53,7 @@ static void io_w8(AVTextWriterContext *wctx, int
> > b)
> > > static void io_put_str(AVTextWriterContext *wctx, const char
> *str)
> > > {
> > > IOWriterContext *ctx = wctx->priv;
> > > - avio_write(ctx->avio_context, str, strlen(str));
> > > + avio_write(ctx->avio_context, (const unsigned char *)str,
> > (int)strlen(str));
> > > }
> > >
> > > static void io_printf(AVTextWriterContext *wctx, const char *fmt,
> > ...)
> > > @@ -78,10 +78,12 @@ const AVTextWriter avtextwriter_avio = {
> > >
> > > int avtextwriter_create_file(AVTextWriterContext **pwctx, const
> > char *output_filename)
> > > {
> > > + if (!pwctx || !output_filename || !output_filename[0])
> > > + return AVERROR(EINVAL);
> >
> > You said in [1] that you removed all these impossible checks, yet
> here
> > they are; they are also above.
> >
> > [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2025-
> April/342317.html
>
> The next commit removes it.
In V3, I have squashed it into the previous commit.
Thanks,
sw
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
