On Tue, Aug 25, 2015 at 9:03 PM, Timothy Gu <timothyg...@gmail.com> wrote: > On Tue, Aug 25, 2015 at 08:19:59PM -0400, Ganesh Ajjanagadde wrote: >> For consistency, prefix with an opt_? > > This name is chosen to be consistent with other show_ functions. opt_* > are exclusively used for setting some options AFAICT.
Ok. Please place the function outside of all the opt_* stuff; since this is not setting options, it should not be in the middle of them. Otherwise, patch LGTM. > >> Maybe you could check the return value of printf? > > Absolutely zero calls to printf in FFmpeg are checked. Even if checking > the result code can be more secure, it is way outside the scope of this > patch. Perhaps. My point was not so much from the position of security, but program correctness: a non zero printf return should propagate to the exit code. You are right this is beyond this patch's scope. > > Timothy > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
