Re: [FFmpeg-devel] [PATCH 01/15] avcodec/motionpixels: Avoid av_unused

[James Almer]

On 4/10/2025 7:36 PM, Andreas Rheinhardt wrote:

James Almer:

 From 9f052c0377a5b46e48d928f11d1d10c389ea5e84 Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <andreas.rheinha...@outlook.com>
Date: Thu, 10 Apr 2025 13:41:55 +0200
Subject: [PATCH 03/15] avutil/aes: Use #if checks instead of if
(ARCH_X86)

Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@outlook.com>
---
  libavutil/aes.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libavutil/aes.c b/libavutil/aes.c
index 13a34c3bf6..3c8ac1c349 100644
--- a/libavutil/aes.c
+++ b/libavutil/aes.c
@@ -237,8 +237,9 @@ int av_aes_init(AVAES *a, const uint8_t *key, int
key_bits, int decrypt)

      a->crypt = decrypt ? aes_decrypt : aes_encrypt;
-    if (ARCH_X86)
-        ff_init_aes_x86(a, decrypt);
+#if ARCH_X86
+    ff_init_aes_x86(a, decrypt);
+#endif

2.45.2

     a->rounds = rounds;      ff_thread_once(&aes_static_init, aes_init_static); --

Why? DCE should handle this fine.

DCE is not mandated by the spec. We should therefore not rely on it. See
also 40e6575aa3eed64cd32bf28c00ae57edc5acb25a.

- Andreas

Ok, LGTM then.

OpenPGP_signature.asc
Description: OpenPGP digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".