On Sat, Mar 22, 2025 at 12:46:19AM +0000, Soft Works wrote: > > > > -----Original Message----- > > From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of > > Michael Niedermayer > > Sent: Samstag, 22. März 2025 01:12 > > To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH v8 0/4] print_graphs: Complete > > Filtergraph Printing > > > > Hi > > > > On Fri, Mar 21, 2025 at 06:52:20PM +0000, Soft Works wrote: > > > > > > > > > > -----Original Message----- > > > > From: Stefano Sabatini <stefa...@gmail.com> > > > > Sent: Freitag, 21. März 2025 19:05 > > > > To: FFmpeg development discussions and patches <ffmpeg- > > de...@ffmpeg.org> > > > > Cc: softworkz <softwo...@hotmail.com> > > > > Subject: Re: [FFmpeg-devel] [PATCH v8 0/4] print_graphs: Complete > > > > Filtergraph Printing > > > > > > > > On date Wednesday 2025-03-19 17:04:09 +0000, ffmpegagent wrote: > > > > > Due to the additional work on graph visualization (see > > > > > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2025- > > > > March/341296.html), I > > > > > have removed the two graph printing commits from this patchset > > rather > > > > than > > > > > adding to it, as to avoid wasting the effort already spent on > > > > reviewing. > > > > > > > > > > So, now it's a graph printing patchset without graph printing :-) > > > > > > > > > > All other commits are unchanged from the previous version. I'm > > also > > > > > resubmitting to give it a final run of the tests on various > > platforms. > > > > > > > > > > Thanks > > > > > > > > > > softworkz (4): > > > > > fftools/textformat: Extract and generalize textformat api from > > > > > ffprobe.c > > > > > fftools/ffprobe: Change to use textformat api > > > > > fftools/ffprobe: Rename writer_print_section_* and WriterContext > > > > > fftools/ffprobe: Rename AVTextFormatContext variables (w => tfc) > > > > > > > > I'm fine with the changes assuming it passes fate. > > > > > > It's all green on Patchwork and on the GitHub CI, as well as locally. > > > > > > Michael had reported a file-not-found compilation error with an x86-32 > > target. It appears to be an issue with ccache and the fact that there's > > a new subfolder (which rarely happens). > > > I used the same configure he gave me (except no ccache) and couldn't > > reproduce. > > > > > > > > > I don't know if you have push commit rights, > > > > > > I was going to ask Michael about it, but for now it would be great > > when you would be able to push it. > > > > Iam happy to give you push access as soon as you are listed in the > > MAINTAINER file. We have used that file as a way to keep the process > > of giving git access open and transparent. > > > > Please send some patch that adds you to MAINTAINERs > > I would be willing to maintain subtitle filtering (as it's obviously not > something that you can throw on the table and walk away), it's just not there > yet :-) > And the graph printing of course, but same symptom as above.
> So - for the time being - should I add myself to the bottom section, above > the line "this list is incomplete"? as you probably saw, i have applied the corresponding patch that adds you already. For maintaining existing code, its probably best to talk with the developers that are most active in the specific area first. For newly added code, yes please add yourself to any new "module" you add Thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
