On Sat, Aug 22, 2015 at 05:18:04AM +0200, Máté Sebők wrote: > > > > fails to build with mingw due to missing header > > In file included from ffmpeg/libavdevice/dshow.c:33:0: > > ffmpeg/libavdevice/bdadefs.h:8:24: fatal error: combaseapi.h: No such > > file or directory > > compilation terminated. > > make: *** [libavdevice/dshow.o] Error 1 > > maybe a header check is needed in configure > > > Maybe fixed... unnecessary headers removed (also some cleanup in the > interface-descriptions)
i can confirm, the new patch builds fine with mingw here [...] > > + > > > + gfilename = malloc((strlen(ctx->dtv_graph_ > > file)+4)*sizeof(WCHAR)); > > is this intended to be malloc() instead of av_malloc() ? > > > Yes, it was intended, only a filename buffer for char-to-widechar > conversion. normally code in FFmpeg uses av_malloc() unless there is need for the buffer to be passed into external functions which require a different allocation full review left to roger and anyone else who wants to review Thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is poorly written but fully understood is good. Rewriting code that one doesnt understand is a sign that one is less smart then the original author, trying to rewrite it will not make it better.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
