On Sat, Dec 21, 2024 at 7:19 PM Michael Niedermayer <mich...@niedermayer.cc> wrote:
> Found-by: Youngjae Choi <youngjaec...@korea.ac.kr> > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > --- > libavutil/timecode.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavutil/timecode.c b/libavutil/timecode.c > index f40a10eb385..f454466f975 100644 > --- a/libavutil/timecode.c > +++ b/libavutil/timecode.c > @@ -61,8 +61,8 @@ uint32_t av_timecode_get_smpte_from_framenum(const > AVTimecode *tc, int framenum) > framenum = av_timecode_adjust_ntsc_framenum2(framenum, tc->fps); > ff = framenum % fps; > ss = framenum / fps % 60; > - mm = framenum / (fps*60) % 60; > - hh = framenum / (fps*3600) % 24; > + mm = framenum / (fps*60LL) % 60; > + hh = framenum / (fps*3600LL) % 24; > return av_timecode_get_smpte(tc->rate, drop, hh, mm, ss, ff); > } > lgtm, but I'd move the c94875471e3ba3dc396c6919ff3ec9b14539cd71 hash in the body of the commit rather than the title for readability/seo -- Vittorio _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
