Hi Niklas On Mon, Dec 02, 2024 at 01:14:09PM +0100, Niklas Haas wrote: > From: Niklas Haas <g...@haasn.dev> > > The basic problem here is that the rgb*ToUV_half_* functions hard-code a > bilinear downsample from src[i] + src[i+1], with no bounds check on the i+1 > access. > > Due to the signature of the function, we cannot easily plumb the "true" width > into the function body to perform a bounds check. Similarly, we cannot easily > pre-pad the input because it is typically reading from the original input > frame, which would require a full memcpy to pad. Either of these solutions are > more trouble than the feature is worth, so just disable it on odd input sizes. > > Fixes: use of uninitialized value > Fixes: ticket #11265 > Signed-off-by: Niklas Haas <g...@haasn.dev> > Sponsored-by: Sovereign Tech Fund > --- > libswscale/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
The input generally should be padded, but teh padding may not have been initialized or may contain things next to the frame being scaled. The patch is probably ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB it is not once nor twice but times without number that the same ideas make their appearance in the world. -- Aristotle
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
