On 11/1/2024 1:52 PM, Michael Niedermayer wrote:
On Tue, Oct 29, 2024 at 07:19:13PM -0300, James Almer wrote:Checking for AV_PIX_FMT_X2RGB10 means the condition will succeed only for the version matching the host's endinaness, when only LE is supported, and thus the wrong path will be taken on BE systems.Signed-off-by: James Almer <jamr...@gmail.com> --- libswscale/output.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)breaks (qemu) mips --- src/tests/ref/fate/filter-pixdesc-x2rgb10le 2024-10-26 22:34:14.532454440 +0200 +++ tests/data/fate/filter-pixdesc-x2rgb10le 2024-11-01 17:50:04.659478576 +0100 @@ -1 +1 @@ -pixdesc-x2rgb10le d34a932222b55f4041742b95837b272e +pixdesc-x2rgb10le 45f6ccc4efa56ae1b38f4741b12e1a75 Test filter-pixdesc-x2rgb10le failed. Look at tests/data/fate/filter-pixdesc-x2rgb10le.err for details. make: *** [src/tests/Makefile:315: fate-filter-pixdesc-x2rgb10le] Error 1 make: *** Waiting for unfinished jobs.... --- src/tests/ref/fate/filter-pixdesc-x2bgr10le 2024-10-26 22:34:14.532454440 +0200 +++ tests/data/fate/filter-pixdesc-x2bgr10le 2024-11-01 17:50:04.675478694 +0100 @@ -1 +1 @@ -pixdesc-x2bgr10le 0ea287ba7ea42330714e7020f2fde7d0 +pixdesc-x2bgr10le f9ce2cc71dc00df2c212b68caf181765 Test filter-pixdesc-x2bgr10le failed. Look at tests/data/fate/filter-pixdesc-x2bgr10le.err for details. make: *** [src/tests/Makefile:315: fate-filter-pixdesc-x2bgr10le] Error 1
I see now that ff_yuv2rgb_c_init_tables() byteswaps the tables, so i guess this change isn't needed and I'm dropping it (Updated the branch as well).
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
