On Mon, 07 Oct 2024 00:15:32 +0200 Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sat, Oct 05, 2024 at 09:23:55PM +0200, Niklas Haas wrote: > > From: Niklas Haas <g...@haasn.dev> > > > > This is done for consistency with the other public enums which will be > > added in the upcoming swscale API refactor. I went through the code and > > checked > > carefully that the value of `dither` is never implicitly compared against > > zero, so this change should not break anything. > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Niklas Haas <g...@haasn.dev> > > --- > > libswscale/swscale_internal.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > this breaks: > > ./ffmpeg -i lena.pnm -vf > scale=iw:ih:flags=0x000002:sws_dither=0,format=bgr4_byte -bitexact > whatever.bmp
This is expected, of course. Are you saying that the change in consistency is not worth the risk of breaking users who directly specify numeric IDs instead of using the symbolic names? I am fine dropping this commit for now. > > thx > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Many things microsoft did are stupid, but not doing something just because > microsoft did it is even more stupid. If everything ms did were stupid they > would be bankrupt already. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
