tis 2024-09-10 klockan 16:06 +0200 skrev Martin Schitter:
> ---
>  libavformat/mxf.c    | 1 +
>  libavformat/mxfdec.c | 1 +
>  2 files changed, 2 insertions(+)

Commit message could be better, something like "Add DNxUncompressed
ULs"

> diff --git a/libavformat/mxf.c b/libavformat/mxf.c
> index a73e40e..35fb73e 100644
> --- a/libavformat/mxf.c
> +++ b/libavformat/mxf.c
> @@ -61,6 +61,7 @@ const MXFCodecUL ff_mxf_codec_uls[] = {
>      { { 
> 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x02,0x02,0x71,0x00,0x00,0x00
>  }, 13,      AV_CODEC_ID_DNXHD }, /* SMPTE VC-3/DNxHD */
>      { { 
> 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x04,0x01,0x02,0x02,0x03,0x02,0x00,0x00
>  }, 14,      AV_CODEC_ID_DNXHD }, /* SMPTE VC-3/DNxHD */
>      { { 
> 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x0E,0x04,0x02,0x01,0x02,0x04,0x01,0x00
>  }, 16,      AV_CODEC_ID_DNXHD }, /* SMPTE VC-3/DNxHD Legacy Avid Media 
> Composer MXF */
> +    { { 
> 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x01,0x0E,0x04,0x02,0x01,0x02,0x1E,0x01,0x00
>  }, 16,      AV_CODEC_ID_DNXUC }, /* DNxUncompressed/SMPTE RDD 50 */

Are really all 16 bytes significant?

>      { { 
> 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0A,0x04,0x01,0x02,0x02,0x01,0x32,0x00,0x00
>  }, 14,       AV_CODEC_ID_H264 }, /* H.264/MPEG-4 AVC Intra */
>      { { 
> 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0A,0x04,0x01,0x02,0x02,0x01,0x31,0x11,0x01
>  }, 14,       AV_CODEC_ID_H264 }, /* H.264/MPEG-4 AVC SPS/PPS in-band */
>      { { 
> 0x06,0x0E,0x2B,0x34,0x04,0x01,0x01,0x0A,0x04,0x01,0x02,0x01,0x01,0x02,0x02,0x01
>  }, 16,       AV_CODEC_ID_V210 }, /* V210 */
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index ac63c0d..142b3e6 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c
> @@ -1597,6 +1597,7 @@ static const MXFCodecUL 
> mxf_picture_essence_container_uls[] = {
>      { { 
> 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x07,0x0d,0x01,0x03,0x01,0x02,0x0c,0x01,0x00
>  }, 14,   AV_CODEC_ID_JPEG2000, NULL, 14, J2KWrap },
>      { { 
> 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x02,0x0d,0x01,0x03,0x01,0x02,0x10,0x60,0x01
>  }, 14,       AV_CODEC_ID_H264, NULL, 15 }, /* H.264 */
>      { { 
> 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x02,0x0d,0x01,0x03,0x01,0x02,0x11,0x01,0x00
>  }, 14,      AV_CODEC_ID_DNXHD, NULL, 14 }, /* VC-3 */
> +    { { 
> 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x02,0x0d,0x01,0x03,0x01,0x02,0x1e,0x01,0x00
>  }, 14,      AV_CODEC_ID_DNXUC, NULL, 14 }, /* DNxUncompressed / SMPTE RDD 50 
> */

Here we have 14.. Also maybe we shouldn't copypaste ULs like this?

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to