On Mon, 2 Sep 2024, at 18:48, James Almer wrote: > On 9/2/2024 9:03 AM, Derek Buitenhuis wrote: >> On 8/31/2024 5:31 PM, James Almer wrote: >>> Signed-off-by: James Almer <jamr...@gmail.com> >>> --- >>> libavcodec/avcodec.c | 2 ++ >>> libavcodec/avcodec.h | 5 +++++ >>> libavcodec/decode.c | 42 +++++++++++++++++++++++++++++++++++++- >>> libavcodec/internal.h | 2 ++ >>> libavcodec/lcevcdec.c | 2 ++ >>> libavcodec/options_table.h | 1 + >>> libavcodec/pthread_frame.c | 7 +++++++ >>> 7 files changed, 60 insertions(+), 1 deletion(-) >> >> No real opinion on the other patches, but this one feels really gross. I feel >> liek we should not be adding new codec-specific things in AVCodecInternal or >> in generic threding, decode, etc. It really feels quite wrong. > > I could try to make it a bit more opaque to decode.c, making i call a > function that would then set any needed post processing callback or > something like that.
If you could, that would be neat: I was also frustrated by this patch in the serie. -- Jean-Baptiste Kempf - President +33 672 704 734 https://jbkempf.com/ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
