On Tue, Jul 16, 2024 at 07:11:22PM +0200, Anton Khirnov wrote:
> FFV1 decoder and encoder currently use the same struct - FFV1Context -
> both as codec private data and per-slice context. For this purpose
> FFV1Context contains an array of pointers to per-slice FFV1Context
> instances.
>
> This pattern is highly confusing, as it is not clear which fields are
> per-slice and which per-codec.
>
> Address this by adding a new struct storing only per-slice data. Start
> by moving slice_{x,y,width,height} to it.
> ---
> libavcodec/ffv1.c | 15 ++++++---
> libavcodec/ffv1.h | 13 +++++---
> libavcodec/ffv1dec.c | 76 ++++++++++++++++++++++++--------------------
> libavcodec/ffv1enc.c | 25 ++++++++-------
> 4 files changed, 76 insertions(+), 53 deletions(-)LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "Nothing to hide" only works if the folks in power share the values of you and everyone you know entirely and always will -- Tom Scott
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
