Re: [FFmpeg-devel] [PATCH 11/11] avcodec/aac/aacdec_usac: Remove check for impossible sbr_ratio

[Lynne via ffmpeg-devel]

On 01/07/2024 01:12, Michael Niedermayer wrote:

Fixes: CID1605475 Logically dead code
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc>
---
  libavcodec/aac/aacdec_usac.c | 3 ---
  1 file changed, 3 deletions(-)

diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
index 9587348021e..10121dbc34f 100644
--- a/libavcodec/aac/aacdec_usac.c
+++ b/libavcodec/aac/aacdec_usac.c
@@ -1676,9 +1676,6 @@ int ff_aac_usac_decode_frame(AVCodecContext *avctx, 
AACDecContext *ac,
      } else if (sbr_ratio == 3) {
          ratio_mult = 2;
          ratio_dec = 1;
-    } else if (sbr_ratio == 4) {
-        ratio_mult = 4;
-        ratio_dec = 1;
      } else {
          ratio_mult = 1;
          ratio_dec = 1;

Or mark it as a false positive?

Its valid, just not supported at the moment. Maybe just error out with PATCHWELCOME?

OpenPGP_0xA2FEA5F03F034464.asc
Description: OpenPGP public key

OpenPGP_signature.asc
Description: OpenPGP digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".