On Thu, Jun 13, 2024 at 11:37:13AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Wed, Jun 12, 2024 at 03:48:21PM +0200, Andreas Rheinhardt wrote: > >> Several of the potential choices of comparison functions > >> need an initialized MpegEncContext (initialized for encoding, > >> not only ff_mpv_common_init()) or they crash when called. > >> Modify ff_set_cmp() to check for this. > >> > >> Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@outlook.com> > >> --- > > > > I dont think they always crashed, so to me marking these as > > unsupported now feels a bit strange. But it shows we where lacking > > testing > > Why don't you just try: > for codec in svq1 snow; do for cmp in dct psnr bit rd dctmax 14; do > ./ffmpeg_g -hide_banner -filter_complex nullsrc -c:v "$codec" -cmp > "$cmp" -f null -; done; done > yourself?
I did misread your patch, i thought you where disabling them for all cases. Yes svq1 & snow probably didnt work with them thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after the Ignorance, they as if into a greater darkness enter who devote themselves to the Knowledge alone. -- Isha Upanishad
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
