Rémi Denis-Courmont: > Le tiistaina 11. kesäkuuta 2024, 21.52.30 EEST James Almer a écrit : >> It's more descriptive of what it does. >> >> Signed-off-by: James Almer <jamr...@gmail.com> >> --- >> libavutil/common.h | 16 +++++++++++++++- >> libavutil/version.h | 1 + >> libavutil/x86/intmath.h | 6 +++--- >> 3 files changed, 19 insertions(+), 4 deletions(-) >> >> diff --git a/libavutil/common.h b/libavutil/common.h >> index 3e4c339893..acd041fb67 100644 >> --- a/libavutil/common.h >> +++ b/libavutil/common.h >> @@ -42,6 +42,7 @@ >> #include "attributes.h" >> #include "error.h" >> #include "macros.h" >> +#include "version.h" >> >> #ifdef HAVE_AV_CONFIG_H >> # include "config.h" >> @@ -122,9 +123,11 @@ >> #ifndef av_clip_uintp2 >> # define av_clip_uintp2 av_clip_uintp2_c >> #endif >> +#if FF_API_MOD_UINTP2 >> #ifndef av_mod_uintp2 >> # define av_mod_uintp2 av_mod_uintp2_c >> #endif >> +#endif >> #ifndef av_sat_add32 >> # define av_sat_add32 av_sat_add32_c >> #endif >> @@ -149,6 +152,9 @@ >> #ifndef av_clipd >> # define av_clipd av_clipd_c >> #endif >> +#ifndef av_zero_extend >> +# define av_zero_extend av_zero_extend_c >> +#endif >> #ifndef av_popcount >> # define av_popcount av_popcount_c >> #endif > > What's the breakdown between common and intmath and where should new > functions > be defined? >
intmath.h is private, common.h is public. That's the difference. Most of these misc-math functions are integer only (IIRC with the exception of floating point clip functions). We should probably move these functions to a new header intmath.h and make it public (the old intmath.h would be renamed to intmath_internal.h or so). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
