On Sun, Jun 02, 2024 at 02:02:53PM +0200, Gerion Entrup wrote: > Actually, the jaccard distance is defined as D = 1 - intersect / union. > Additionally, the distance value is compared against a constant that > must be between 0 and 1, which is not the case here. Both facts together > has led to the fact, that the function always returned a matching course > signature. To leave the constant intact and to avoid floating point > computation, this commit multiplies with 1 << 16 making the constant > effectively 9000 / (1<<16) =~ 0.14. > > Reported-by: Sachin Tilloo <sachin.til...@gmail.com> > Reviewed-by: Sachin Tilloo <sachin.til...@gmail.com> > Tested-by: Sachin Tilloo <sachin.til...@gmail.com> > --- > Sorry, it should apply clean now. > > libavfilter/signature_lookup.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is less readable
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
