Rémi Denis-Courmont:
> Le keskiviikkona 29. toukokuuta 2024, 22.55.13 EEST Andreas Rheinhardt a 
> écrit 
> :
>> It seems to me that the flac encoder can use odd values (namely if the
>> user set an odd frame_size option or if it gets fed an odd number of
>> samples in which case the last frame will have an odd number of samples).
> 
> As noted earlier the C code seems to assume that len is even, and fixing it 
> is 
> outside the scope of this patch.
> 

I never said you should fix it, but you should not claim in your commit
message that the actual code is not used with odd lengths.

- Andreas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to