Michael Niedermayer:
> Help coverity with CID500302 Uninitialized scalar variable
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc>
> ---
> libavformat/img2dec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c
> index a40675d4341..6220003fb4d 100644
> --- a/libavformat/img2dec.c
> +++ b/libavformat/img2dec.c
> @@ -25,6 +25,7 @@
> #define _DEFAULT_SOURCE
> #define _BSD_SOURCE
> #include <sys/stat.h>
> +#include "libavutil/avassert.h"
> #include "libavutil/avstring.h"
> #include "libavutil/log.h"
> #include "libavutil/mem.h"
> @@ -504,6 +505,7 @@ int ff_img_read_packet(AVFormatContext *s1, AVPacket *pkt)
> pkt->flags |= AV_PKT_FLAG_KEY;
> if (s->ts_from_file) {
> struct stat img_stat;
> + av_assert0(!s->is_pipe);
> if (stat(filename, &img_stat)) {
> res = AVERROR(EIO);
> goto fail;
1. You seem to refer to 1500302 which I can't even select any more
because it has been dismissed.
2. Why are you using av_assert0 to help coverity?
3. In cases like these it would be important to actually note why this
assert can't be triggered. With a comment like "The ts_from_file option
is not supported by piped input demuxers".
4. I just sent an alternative for this:
https://ffmpeg.org/pipermail/ffmpeg-devel/2024-May/327035.html. I don't
know which one should be preferred or whether the code should be left as-is.
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
