On Wed, 1 May 2024, Poorva wrote:
On Fri, Apr 5, 2024 at 2:08 AM Marton Balint <c...@passwd.hu> wrote:On Mon, 1 Apr 2024, Poorva wrote: >> >> >> > On Sun, Mar 31, 2024 at 8:35 PM Marton Balint <c...@passwd.hu> wrote: > >> >> >> On Fri, 29 Mar 2024, Poorva wrote: >> >>>> >>> >>> On Tue, Mar 26, 2024 at 2:36 AM Poorva <2003gaikarpoo...@gmail.com> >> wrote: >>>>> >>>>> >>>> >>>> >>>> Thank you for your feedback on the Git patch I submitted for review. >>>> I have rectified the problem by adding the necessary changes . >>>> The updated patch file is attached for your review. >>>>> >>>>> >>> I wanted to follow up on the patch titled >>> "v3-0001-avfilter-f_select.c - Add Support for IW and IH" that I >>> submitted earlier and provide an update based on the feedback >>> received. >>> >>> In response to your suggestion about the switch block, I have >>> integrated the changes into the existing switch block for >>> AVMEDIA_TYPE_VIDEO. Additionally, I have removed an unnecessary new >>> line that was added at the end of the file. >>> >>> Despite these modifications, I have not received any further feedback >>> or comments on the patch. Therefore, I kindly request the community to >>> review the updated patch attached to this email. >> >> [..] >> >>> @@ -371,6 +383,7 @@ FF_ENABLE_DEPRECATION_WARNINGS >>> break; >>> } >>> >>> + >>> select->select = res = av_expr_eval(select->expr, >> select->var_values, NULL); >>> av_log(inlink->dst, AV_LOG_DEBUG, >>> "n:%f pts:%f t:%f key:%d", >>> @@ -545,4 +558,4 @@ const AVFilter ff_vf_select = { >>> FILTER_QUERY_FUNC(query_formats), >>> .flags = AVFILTER_FLAG_DYNAMIC_OUTPUTS | >> AVFILTER_FLAG_METADATA_ONLY, >>> }; >>> -#endif /* CONFIG_SELECT_FILTER */ >>> +#endif /* CONFIG_SELECT_FILTER */ >>> \ No newline at end of file >>> -- >>> 2.43.0.windows.1 >>> >> >> These two whitespace changes are still unnecessary. Please check your >> patch before sending. >> >> I did remove all the unnecessary whitespaces ,rest which are present are > to keep the code style . > Patch is attached to this email. No, the last hunk still removes a newline.Sir, as far as I know git does that automatically.
I don't think git does this, maybe your editor? In any case, I have amended the patch locally, will apply soon. Thanks, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
