May 2, 2024, 02:42 by mich...@niedermayer.cc: > Fixes: CID1543204 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > --- > libavcodec/avfft.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/avfft.c b/libavcodec/avfft.c > index f6787937f67..0f43f30b776 100644 > --- a/libavcodec/avfft.c > +++ b/libavcodec/avfft.c > @@ -158,7 +158,7 @@ RDFTContext *av_rdft_init(int nbits, enum > RDFTransformType trans) > return NULL; > } > > - s->stride = (trans == DFT_C2R) ? sizeof(AVComplexFloat) : sizeof(float); > + s->stride = sizeof(float); > s->len = 1 << nbits; > s->inv = trans == IDFT_C2R; >
That's not right. While it's true that currently the stride parameter in av_tx_fn is unused for RDFTs, that may not always be the case, and the documentation requires that the stride is valid and set to the value that the current implementation assumes, so that nothing breaks once that is implemented. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
