On 03/04/2024 21:09, Rémi Denis-Courmont wrote:
Le keskiviikkona 3. huhtikuuta 2024, 22.44.29 EEST Mark Thompson a écrit :
libva 2.0 was released in 2017 and the 2.x versions are included in all
supported distributions nowadays.
---
libavutil/hwcontext_vaapi.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
index 56d03aa4cd..bc82ab31e6 100644
--- a/libavutil/hwcontext_vaapi.c
+++ b/libavutil/hwcontext_vaapi.c
@@ -1637,7 +1637,6 @@ static void vaapi_device_free(AVHWDeviceContext *ctx)
av_freep(&priv);
}
-#if CONFIG_VAAPI_1
IMO, it wouldn't hurt to clarify in the change description that CONFIG_VAAPI_1
actually corresponded to libva 2.x. No objections to the code changes though.
Fair, the library major version being the API major version plus one is a
slightly bizarre feature. I've added some words to that effect locally.
Thanks,
- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
