On Thu, Jul 23, 2015 at 7:02 PM, Derek Buitenhuis
<derek.buitenh...@gmail.com> wrote:
> On 7/23/2015 5:41 PM, Steve Lhomme wrote:
>> --
>> favor link over link.exe in case some wrapper script already exists
>> fallback to "link" in the path if the one next to cl is not found
>> ---
>>  configure       | 2 +-
>>  tools/mslink.sh | 9 +++++++++
>
> Should be under compat.

Fixed in the next version.

>> diff --git a/tools/mslink.sh b/tools/mslink.sh
>> new file mode 100644
>
> Broken permissions.

Not sure how I can tweak that under Windows.

> Can do without the .sh extension (see for example, makedef).
>
>> index 0000000..6f0d98f
>> --- /dev/null
>> +++ b/tools/mslink.sh
>> @@ -0,0 +1,9 @@
>> +#!/bin/sh
>> +
>> +LINK_EXE_PATH=$(dirname "`command -v cl`")/link
>
> Be consistent with the usage of $().

What's the other alternative ? dirname is always used as $(dirname
$xyz) in configure.

>
> The idea itself seems reasonable.
>
> - Derek
> _______________________________________________
> libav-devel mailing list
> libav-de...@libav.org
> https://lists.libav.org/mailman/listinfo/libav-devel
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to