>From: ffmpeg-devel <ffmpeg-devel-boun...@ffmpeg.org> On Behalf Of >Hendrik Leppkes >Sent: Thursday, March 28, 2024 5:43 PM >To: FFmpeg development discussions and patches <ffmpeg- >de...@ffmpeg.org> >Subject: Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: fix the problem of >memcmp losing effectiveness > >On Thu, Mar 28, 2024 at 10:12 AM <tong1.wu-at-intel....@ffmpeg.org> >wrote: >> >> From: Tong Wu <tong1...@intel.com> >> >> HEVCHdrParams* receives a pointer which points to a dynamically >> allocated memory block. It causes the memcmp always returning 1. >> Add a function to do the comparision. A condition is also added to >> avoid malloc(0). >> >> Signed-off-by: Tong Wu <tong1...@intel.com> > >I've been looking into some playback glitches after >456c8ebe7c7dcd766d36cd0296815d89fd1166b5 and I can confirm that this >patch fixes those as well. > >Using the fixed position of the *hdr member and its offset seems a bit >icky though, and _at least_ could use a comment so future changes keep >it last.
Comment is added to the header. Thanks, Tong _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
