Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-12 09:56:46) >> Anton Khirnov: >>> Otherwise it might conflict with caller-defined identifiers. >>> >>> ff because it is not supposed to be used by external callers. >>> --- >> >> This is public, so it should be av_attribute_deprecated. > > As the commit message says, this is not supposed to be used by external > callers. Or do you see any reason why it should be public? >
It is public given that it is declared in a public header. That is what matters. Furthermore, we have used the FF_ and AV_ prefixes for public macros and the av_ prefix for public symbols, but IIRC we do not use the ff_ prefix for public symbols at all, therefore I'd like us not to reserve another namespace. >> For the same reason it is actually an API break to no longer provide the >> un-prefixed version. > > I am still providing the unprefixed version under a deprecation guard. > I overlooked that. >> Is this just a general precaution or did you run into an actual conflict? > > The former. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
