On Sun, Mar 10, 2024 at 07:40:47PM -0500, Marth64 wrote: > Currently, Closed Captions decoder prints multiple \pos ASS tags per line, > per cue. This is invalid behavior, because only the first \pos tag in a cue > is honored by ASS anyway. Don't write multiple \pos tags. > > Signed-off-by: Marth64 <mart...@proxyid.net> > --- > libavcodec/ccaption_dec.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-)
This breaks fate
--- ./tests/ref/fate/sub-cc-scte20 2024-03-05 02:37:36.223299993 +0100
+++ tests/data/fate/sub-cc-scte20 2024-03-11 22:13:08.091910294 +0100
@@ -13,5 +13,5 @@
[Events]
Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text
Dialogue: 0,0:00:00.00,0:00:01.44,Default,,0,0,0,,{\an7}{\pos(48,182)}BESIDES
THE
-Dialogue:
0,0:00:01.43,0:00:03.93,Default,,0,0,0,,{\an7}{\pos(38,166)}\hBESIDES THE
\N{\an7}{\pos(38,197)}SPENDING AND THIS, IS THAT CAR
-Dialogue: 0,0:00:03.94,0:00:06.31,Default,,0,0,0,,{\an7}{\pos(38,182)}SPENDING
AND THIS, IS THAT CAR \N{\an7}{\pos(38,197)}MANUFACTURERS ARE ABOUT AS
+Dialogue:
0,0:00:01.43,0:00:03.93,Default,,0,0,0,,{\an7}{\pos(38,166)}\hBESIDES THE
\NSPENDING AND THIS, IS THAT CAR
+Dialogue: 0,0:00:03.94,0:00:06.31,Default,,0,0,0,,{\an7}{\pos(38,182)}SPENDING
AND THIS, IS THAT CAR \NMANUFACTURERS ARE ABOUT AS
Test sub-cc-scte20 failed. Look at tests/data/fate/sub-cc-scte20.err for
details.
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Nations do behave wisely once they have exhausted all other alternatives.
-- Abba Eban
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
