On 06/03/2024 16:09, Stefano Sabatini wrote:
On date Wednesday 2024-03-06 01:19:11 -0600, Marth64 wrote:
Since last iteration: removes unused variable in dvdclut.c

Signed-off-by: Marth64 <mart...@proxyid.net>
---
  doc/demuxers.texi         |  5 +++
  libavformat/Makefile      |  2 +-
  libavformat/dvdclut.c     | 75 +++++++++++++++++++++++++++++++++++++++
  libavformat/dvdclut.h     | 37 +++++++++++++++++++
  libavformat/dvdvideodec.c | 15 ++++++++
  5 files changed, 133 insertions(+), 1 deletion(-)
  create mode 100644 libavformat/dvdclut.c
  create mode 100644 libavformat/dvdclut.h

diff --git a/doc/demuxers.texi b/doc/demuxers.texi
index f4bac8f3b3..1a17c6db16 100644
--- a/doc/demuxers.texi
+++ b/doc/demuxers.texi
@@ -394,6 +394,11 @@ often with junk data intended for controlling a real DVD 
player's
  buffering speed and with no other material data value.
  Default is 1, true.

+@item clut_rgb @var{bool}
+Output subtitle palettes (CLUTs) as RGB, required for Matroska.
+Disable to output the palette in its original YUV colorspace.
+Default is 1, true.

Can you expand about this? When is matroska used in a DVD?

Sounds to me like muxing _to_ matroska needs RGB palettes, but DVDs bring YUV ones.

Can we make the setting automatic in case matroska is detected?

[...]

LGTM otherwise.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to