Le sam. 24 févr. 2024 à 19:27, Michael Niedermayer <mich...@niedermayer.cc> a écrit : > > On Fri, Feb 23, 2024 at 02:41:06PM -0600, Romain Beauxis wrote: > > The new default channel layout for the various RIFF/WAV decoders is not > > backward compatible. > > > > Historically, most decoders will expect the channel layouts to follow > > the native layout up-to a reasonable number of channels. > > > > Additionally, non-native layouts are causing troubles with filters > > chaining. > > > > This PR changes the default channel layout reported by RIFF/WAV decoders > > to default to the native layout when the number of channels is up-to 8. > > > > The logic for these changes is the same as the logic for the vorbis/opus > > decoders. > > > > Romain > > breaks fate > make -j32 fate-flcl1905 > TEST flcl1905 > --- ./tests/ref/fate/flcl1905 2024-02-09 03:32:32.540199565 +0100 > +++ tests/data/fate/flcl1905 2024-02-25 02:26:51.079111678 +0100 > @@ -1,192 +1,192 @@ > > packet|codec_type=audio|stream_index=0|pts=0|pts_time=0.000000|dts=0|dts_time=0.000000|duration=22528|duration_time=0.510839|size=4092|pos=56|flags=K__ > -frame|media_type=audio|stream_index=0|key_frame=1|pts=N/A|pts_time=N/A|pkt_dts=N/A|pkt_dts_time=N/A|best_effort_timestamp=N/A|best_effort_timestamp_time=N/A|pkt_duration=22528|pkt_duration_time=0.510839|duration=22528|duration_time=0.510839|pkt_pos=56|pkt_size=4092|sample_fmt=fltp|nb_samples=2048|channels=2|channel_layout=unknown > -frame|media_type=audio|stream_index=0|key_frame=1|pts=N/A|pts_time=N/A|pkt_dts=N/A|pkt_dts_time=N/A|best_effort_timestamp=N/A|best_effort_timestamp_time=N/A|pkt_duration=22528|pkt_duration_time=0.510839|duration=22528|duration_time=0.510839|pkt_pos=56|pkt_size=4092|sample_fmt=fltp|nb_samples=2048|channels=2|channel_layout=unknown > -frame|media_type=audio|stream_index=0|key_frame=1|pts=N/A|pts_time=N/A|pkt_dts=N/A|pkt_dts_time=N/A|best_effort_timestamp=N/A|best_effort_timestamp_time=N/A|pkt_duration=22528|pkt_duration_time=0.510839|duration=22528|duration_time=0.510839|pkt_pos=56|pkt_size=4092|sample_fmt=fltp|nb_samples=2048|channels=2|channel_layout=unknown > ...
Thanks. I did more backward compatibility tests and I might have jumped the gun on it as well. I'll check again and will come back to it if I can confirm anything. -- Romain _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
