On Sat, 24 Feb 2024, Stone Chen wrote:
On Sat, Feb 24, 2024 at 6:34 PM Marton Balint <c...@passwd.hu> wrote:
On Sat, 24 Feb 2024, Stone Chen wrote:
On Sat, Feb 24, 2024 at 3:56 PM Marton Balint <c...@passwd.hu> wrote:
On Sat, 24 Feb 2024, Stone Chen wrote:
Previously to support dynamic reconfigurations of the matrix string
(e.g. 0m), the rdiv values would always be cleared to 0.f, causing the
rdiv
to be recalculated based on the new filter. This however had the side
effect of always ignoring user specified rdiv values.
Instead float user_rdiv[0] is added to ConvolutionContext which will
store the user specified rdiv values. Then the original rdiv array will
store either the user_rdiv or the automatically calculated 1/sum.
This fixes trac #10294, #10867
Have you tested?
Thanks,
Marton
Hi Marton,
Yes I've tested that
- the original behavior works (automatically calculate rdiv if
user_rdiv
= 0)
- setting the rdiv value works
It does not work for me even after applying your patch.
Regards,
Marton
Hi Marton,
Sorry about that, was it with the attached patch in the second email? I had
botched my initial patch, I've re-attached the second to this email.
Oh, sorry, I missed that the second patch is different. Use versions in
email subjects, such as [PATCH v2] for new versions of the same patch.
Looking good now, will apply.
Thanks,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
