On 2015-07-17 12:55, Paul B Mahol wrote:
> On 7/17/15, James Darnley <james.darn...@gmail.com> wrote:
>> On 2015-07-09 18:55, Paul B Mahol wrote:
>>> + { "n", "enable channels coupling", OFFSET(channels_coupled),
>>> AV_OPT_TYPE_INT, {.i64 = 1}, 0, 1, FLAGS },
>>
>> This should be "enable channel coupling"
>
> Fixed
>
>>
>>> +static const double s_pi =
>>> 3.1415926535897932384626433832795028841971693993751058209749445923078164062862089986280348253421170679;
>>
>> Why not use the standard M_PI define?
>
> Its too short. And I try hard to produce exact same output as
> reference implementation as possible, even if doubles are used.I would have expected it to be long enough to be as precise as double can be, or an exact hex define. Colour me surprised. I don't object then.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
