> On Feb 4, 2024, at 13:44, James Almer <jamr...@gmail.com> wrote: > > On 2/4/2024 8:16 AM, Cosmin Stejerean via ffmpeg-devel wrote: >> From: Cosmin Stejerean <cos...@cosmin.at> >> >> --- >> tests/fate/mov.mak | 5 +++++ >> tests/ref/fate/mov-read-amve | 8 ++++++++ >> tests/ref/fate/mov-write-amve | 33 +++++++++++++++++++++++++++++++++ >> 3 files changed, 46 insertions(+) >> create mode 100644 tests/ref/fate/mov-read-amve >> create mode 100644 tests/ref/fate/mov-write-amve >> >> diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak >> index f202f36d96..ebad6ff2f4 100644 >> --- a/tests/fate/mov.mak >> +++ b/tests/fate/mov.mak >> @@ -9,6 +9,7 @@ FATE_MOV = fate-mov-3elist \ >> fate-mov-frag-encrypted \ >> fate-mov-tenc-only-encrypted \ >> fate-mov-invalid-elst-entry-count \ >> + fate-mov-write-amve \ >> fate-mov-gpmf-remux \ >> fate-mov-440hz-10ms \ >> fate-mov-ibi-elst-starts-b \ >> @@ -25,6 +26,7 @@ FATE_MOV_FFPROBE = fate-mov-neg-firstpts-discard \ >> fate-mov-zombie \ >> fate-mov-init-nonkeyframe \ >> fate-mov-displaymatrix \ >> + fate-mov-read-amve \ >> fate-mov-spherical-mono \ >> fate-mov-guess-delay-1 \ >> fate-mov-guess-delay-2 \ >> @@ -109,6 +111,9 @@ fate-mov-init-nonkeyframe: CMD = run >> ffprobe$(PROGSSUF)$(EXESUF) -show_packets - >> >> fate-mov-displaymatrix: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_entries >> stream=display_aspect_ratio,sample_aspect_ratio:stream_side_data_list >> -select_streams v -v 0 $(TARGET_SAMPLES)/mov/displaymatrix.mov >> >> +fate-mov-read-amve: CMD = run ffprobe$(PROGSSUF)$(EXESUF) -show_entries >> stream_side_data_list -select_streams v -v 0 $(TARGET_SAMPLES)/mov/amve.mov > > There's no need for this test if you add the other. The writing one > succeeding means the box was read and propagated from the input file. >
That is true, although if the writing fails the read test will still succeed and help point to an error in writing. But if we don't want the extra test I can delete it. >> +fate-mov-write-amve: CMD = transcode mov $(TARGET_SAMPLES)/mov/amve.mov mp4 >> "-c copy" "-c copy -t 0.5" "-show_entries stream_side_data_list" > > -c:v Will fix. - Cosmin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
