On Thu, Jul 16, 2015 at 7:43 PM, Clément Bœsch <u...@pkh.me> wrote:
>> +Reverses a clip. Requires memory to buffer the entire clip, so trimming is 
>> suggested.
>
> We use infinitive form, so "Reverse".

Done locally.

> You might want to print "Warning: this filter requires ..."

Is there any reasonable way to determine when to print such a warning? Seems
silly to warn over e.g. 40 frames.

> Can you add an example to make sure users don't membomb too much their
> OS?

How does this look:

    -vf trim=end=10,reverse

>> +    if (ret == AVERROR_EOF && !ctx->is_disabled && s->nb_frames > 0) {
>
> is_disabled suggest a timeline support. You could add that if you feel
> like it. That way, "reverse=enable='between(t,30,40)'" would reverse only
> between t=30 and t=40 and pass through the rest of the time.

So the other option is to remove the check for it?

- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to