Quoting Andreas Rheinhardt (2024-01-29 11:55:19) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2024-01-29 10:57:19) > >> Anton Khirnov: > >>> +# add libavcodec/ to include path for bsfs > >>> +$(addprefix libavcodec/, $(sort $(filter bsf/%,$(OBJS_BSF-yes)))): > >>> CPPFLAGS += -I$(SRC_PATH)/libavcodec/ > >> > >> 1. Why sort? > > > > To get rid of duplicates, otherwise the flags can be added multiple > > times. > > > > Why not just use libavcodec/bsf/%.o: CPPFLAGS += -I$(SRC_PATH)/libavcodec/
Sure, it just didn't occur to me. > I was actually proposing that the dependencies for stuff in libavcodec/ > stays in libavcodec/Makefile. Okay, then I would appreciate it if you were more explicit about how you want things changed in the future, it would save time. > PS: Why don't you move e.g. bsf_internal.h as well as bsf.c itself? Because I only wanted to move the bitstream filters themselves in this patch. I have no strong feelings about those two files moving under bsf/ or not. > And where has this actually been discussed for there to be > "overwhelming" consensus for it? As I remember it, various people have complained about the number of files in libavcodec/* for years - on IRC, ML, developer meetings, etc. I don'recall anyone ever being against it. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
