On Sat, 27 Jan 2024 at 16:57, Nuo Mi <nuomi2...@gmail.com> wrote: > > > On Sat, Jan 27, 2024 at 10:38 PM James Almer <jamr...@gmail.com> wrote: > >> On 1/27/2024 1:15 AM, Nuo Mi wrote: >> > diff --git a/libavformat/isom_tags.c b/libavformat/isom_tags.c >> > index a575b7c160..705811e950 100644 >> > --- a/libavformat/isom_tags.c >> > +++ b/libavformat/isom_tags.c >> > @@ -123,6 +123,9 @@ const AVCodecTag ff_codec_movvideo_tags[] = { >> > { AV_CODEC_ID_HEVC, MKTAG('d', 'v', 'h', 'e') }, /* HEVC-based >> Dolby Vision derived from hev1 */ >> > /* dvh1 is >> handled within mov.c */ >> > >> > + { AV_CODEC_ID_VVC, MKTAG('v', 'v', 'i', '1') }, /* VVC/H.266 >> which indicates parameter sets may be in ES */ >> > + { AV_CODEC_ID_VVC, MKTAG('v', 'v', 'c', '1') }, /* VVC/H.266 >> which indicates parameter shall not be in ES */ >> > + >> > { AV_CODEC_ID_H264, MKTAG('a', 'v', 'c', '1') }, /* AVC-1/H.264 */ >> > { AV_CODEC_ID_H264, MKTAG('a', 'v', 'c', '2') }, >> > { AV_CODEC_ID_H264, MKTAG('a', 'v', 'c', '3') }, >> > > >> >> This list is for mov only, not mp4. You're already adding these two >> entries to codec_mp4_tags[] bellow, for ISOBMFF. >> > Hi James, > Thank you for the review. > I guess not, @Thomas Siedel <thomas...@spin-digital.com> , could you > give us some insights? > thank you. > >> >> Are these defined anywhere in Apple's documentation? >> > For mov I was only copy&pasting it from mp4 to be honest, without checking the Apple documentation, sorry for that.
Therefore I guess these 2 entries should be removed from the ff_codec_movvideo_tags table. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".