On 1/28/2024 7:41 PM, Michael Niedermayer wrote:
On Sun, Jan 28, 2024 at 02:49:26PM +0100, Andreas Rheinhardt wrote:
This reverts commits fd5aa93a37b3fa21195c6d7b22ef655124020e09
and cf00f60bab1f79213c274a6cd4357b32bd5c0101
("avcodec/kbdwin: Support arbitrary sized windows").

The change in question has only been made for libavradio.
in anticipation of merging it into the main tree. This has
not happened, so this commit reverts the changes to kbdwin
that are not used for anything else. In particular, these
functions are no longer exported (as avpriv functions);
notice that the fixed-point function has been exported
despite having never been used outside of lavc.

Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@outlook.com>
---
  libavcodec/aacdec_template.c |  8 ++++----
  libavcodec/aactab.c          |  4 ++--
  libavcodec/ac3dec.c          |  2 +-
  libavcodec/ac3enc_fixed.c    |  2 +-
  libavcodec/ac3enc_float.c    |  2 +-
  libavcodec/dolby_e.c         |  4 ++--
  libavcodec/kbdwin.c          | 23 ++++++++---------------
  libavcodec/kbdwin.h          | 10 ++++------
  8 files changed, 23 insertions(+), 32 deletions(-)

I still intend to work on SDR either within what people agreed to
(that is a separate library) or in form of a fork.

For both it is easier if the functions it needs are accessible

thx

Renaming an ff_ symbol into avpriv_ can happen at any time. Renaming an avpriv_ symbol to ff_ can only happen during a bump. So this patch is IMO ok. There's no warranty that whatever happens with SDR will happen before the next bump, so better remove as many exposed symbols as possible.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to