On Wed, Dec 13, 2023 at 12:16:56AM +0100, Michael Niedermayer wrote: > On Wed, Dec 13, 2023 at 12:13:36AM +0100, Michael Niedermayer wrote: > > On Mon, Dec 11, 2023 at 08:06:53PM +0100, Clément Bœsch wrote: > > > This byte represents 4 reserved bits followed by 4 alpha_channel_type > > > bits. > > > > > > alpha_channel_type currently has 3 differents defined values: 0 (no > > > alpha), 1 (8b alpha), and 2 (16b alpha), all the other values are > > > reserved. This part is correctly written (alpha_bits>>3 does the correct > > > thing), but the 4 initial bits are reserved. > > > --- > > > libavcodec/proresenc_kostya.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > This breaks fate (not just changing the value but actually breaking it) > > This is about the next patch "avcodec/proresenc_anatoliy: do not write into > alpha reserved bitfields" > I used a too short search string for the subject i replied to ... > (so issue is real but its the next patch) >
Just resent a patchset addressing the FATE issue for all the commits individually (sorry, I only tested with fate-prores initially) I also fixed "do not write into alpha reserved bitfields" which wasn't writing the alpha byte unconditionally. Sorry about the missing v2 in the patchset btw, forgot about it. [...] -- Clément B. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
