Quoting Alexander Strasser (2023-11-26 16:08:42) > On 2023-11-26 10:18 +0100, Anton Khirnov wrote: > > Set pushed. > > > > The general_assembly.pl script should now be usable as the authoritative > > source for GA members. > > The patches mostly LGTM. > > My Perl knowledge in general is really mostly from 20 years ago. > So if there is any Perl-ish devil in the details I surely have > overlooked it. > > Please pardon me if I missed any details on how the program works. > The edge cases are always the tricky stuff... > > One thing about this patch and that program in general is a bit > unfortunate: The use of PerlDate is_between. > > Here is the doc I found for it: > > $dt->is_between( $lower, $upper ) > Checks whether $dt is strictly between two other DateTime objects. > > "Strictly" means that $dt must be greater than $lower and less than > $upper. If it is equal to either object then this method returns false. > > > AFAIU it affects the script in 2 places: > > 1. In subroutine get_date_range: > Here the exact day matching date_ga_rule is treated like > anything >= date_first_regular > > 2. In the loop adding the extra member. The member would not be added > on both, the day they were elected nor the day 2 years after. > > Case 1 should be "strictly academical" and thus not really important > because to my knowledge no vote was started on that day. > > For case 2 it will be not important on most days, but it would seem > more common and intuitive to use either the closed interval or a > half open interval. Where including the first and the last day or > including the first and excluding the day seem most natural to me.
These objects are not days, they are specific times with nanosecond resolution. Since I'm not specifying time in the constructor, it defaults to the first nanosecond-long instant of the day, so none of these problems really apply. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
