Hi, On Mon, Nov 6, 2023 at 7:07 AM Ronald S. Bultje <rsbul...@gmail.com> wrote:
> On Sun, Nov 5, 2023 at 11:13 PM Dai, Jianhui J < > jianhui.j.dai-at-intel....@ffmpeg.org> wrote: > >> > > +static const uint8_t vp8_token_update_probs[4][8][3][11] = { >> > >> > It would be nice if these symbols could be re-used from the existing vp8 >> > native decoder, instead of duplicating them? Both source + binary size >> are >> > relevant here. >> >> Including vp8data.h would introduce many unwanted static tables other >> than vp8_token_update_probs and increase the binary size. >> As suggested in patch v3, it is better to use local defined >> vp8_token_update_probs. >> > > I didn't mean to include vp8data.h. I mean to include a new *.h that > declares extern const uint8_t vp8_token_update_probs[][][][] and move said > table into a new *.c file. The point is to prevent symbol duplication. > And to elaborate further, in case it's unclear: the symbol move means the native VP8 decoder would include this probability table using the same new mechanism also. It would no longer exist in vp8data.h. Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".