On Thu, Jul 09, 2015 at 01:23:58PM +0200, Carl Eugen Hoyos wrote: > Hi! > > RFC 2435 requires standard Huffman tables when sending (m)jpeg over rtp. > Related to ticket #3823. > > Please comment, Carl Eugen
> rtpenc_jpeg.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > f72f54ec4c4d9fb7f8e61dbb4ce48cd5a492c05e patchrtpjpghuffman.diff > diff --git a/libavformat/rtpenc_jpeg.c b/libavformat/rtpenc_jpeg.c > index 7ee26c4..e9d09e9 100644 > --- a/libavformat/rtpenc_jpeg.c > +++ b/libavformat/rtpenc_jpeg.c > @@ -21,6 +21,7 @@ > > #include "libavcodec/bytestream.h" > #include "libavcodec/mjpeg.h" > +#include "libavcodec/jpegtables.h" > #include "libavutil/intreadwrite.h" > #include "rtpenc.h" > > @@ -81,6 +82,26 @@ void ff_rtp_send_jpeg(AVFormatContext *s1, const uint8_t > *buf, int size) > "Only 1x1 chroma blocks are supported. Aborted!\n"); [...] > + "Only standard Huffman tables are supported\n"); I think the error messages should be changed to say that RFC... doesnt allow stuff not that its not supported implying it could be supported [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
