On Fri, 13 Oct 2023 14:33:11 -0400 Vittorio Giovara <vittorio.giov...@gmail.com> wrote: > On Fri, Oct 13, 2023 at 10:27 AM Niklas Haas <ffm...@haasn.xyz> wrote: > > > Changes since v1: > > > > - Remove unneeded patch (AVCodecContext.colorspace init) > > - Merge auto-range conversion into auto-scale filter > > - Replace vf_zscale by vf_colorspace in fftools > > > > Why is this? I haven't checked what vf_colorspace supports in a hot second, > but iirc zscale can handle non linear spaces better and hdr conversion > If it's because it's a built in filter, do you think we could first check > for zscale presence and fallback to colorspace? > > - Add some miscellaneous fixes for various FATE tests > > - Clean up some additional vestigiaul YUVJ remnants > >
N.B.: Another issue with vf_scale/vf_colorspace is that vf_scale currently doesn't handle colorspace metadata at all, which is blocking the ability to add this (easily) to filter negotiation, since filter negotiation hard-codes the "scale" filter for auto-converting between any mismatch. I am considering even just dropping the extended colorspace metadata (primaries, trc) from this series completely, or at least splitting them into separate patchsets. One to only remove YUVJ and add the color range + filter negotiation, and one to add all of the remaining colorspace metadata. Then the bikeshed about how to convert between these remaining bits of metadata can be left to that series, and not block YUVJ removal. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
