On 29.09.2023 15:52, Tristan Matthews wrote:
Fixes: https://trac.ffmpeg.org/ticket/10596
---
  configure | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 20db1801ed..50ba6f772f 100755
--- a/configure
+++ b/configure
@@ -7154,7 +7154,8 @@ enabled crystalhd && check_lib crystalhd "stdint.h 
libcrystalhd/libcrystalhd_if.
if enabled vulkan; then
      check_pkg_config_header_only vulkan "vulkan >= 1.3.255" "vulkan/vulkan.h" 
"defined VK_VERSION_1_3" ||
-        check_cpp_condition vulkan "vulkan/vulkan.h" "defined(VK_VERSION_1_4) || 
(defined(VK_VERSION_1_3) && VK_HEADER_VERSION >= 255)"
+        check_cpp_condition vulkan "vulkan/vulkan.h" "defined(VK_VERSION_1_4) || 
(defined(VK_VERSION_1_3) && VK_HEADER_VERSION >= 255)" ||
+        warn "Disabling vulkan" && disable vulkan
  fi

Doesn't that just always disable vulkan if any of the previous checks succeed? The logic looks weird to me.

Also, shouldn't all of those check_* calls disable vulkan already? That's what the first argument is for.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to