On 19/09/2023 10:18, Roman Arzumanyan wrote:
Hello, Any updates on this patch?
Haven't had time to look at it closely or test it yet. Looks generally okay though.
чт, 14 сент. 2023 г. в 19:52, Roman Arzumanyan <r.arzuman...@visionlabs.ai <mailto:r.arzuman...@visionlabs.ai>>:Got it, thanks. Please find the patches in attachment. Just for my own understanding - could you please explain how this magic works in the configure script? I mean this section: if ! disabled ffnvcodec; then ffnv_hdr_list="ffnvcodec/nvEncodeAPI.h ffnvcodec/dynlink_cuda.h ffnvcodec/dynlink_cuviddec.h ffnvcodec/dynlink_nvcuvid.h" check_pkg_config ffnvcodec "ffnvcodec >= 12.1.14.0" "$ffnv_hdr_list" "" || \ check_pkg_config ffnvcodec "ffnvcodec >= 12.0.16.0ffnvcodec < 12.1" "$ffnv_hdr_list" "" || \ check_pkg_config ffnvcodec "ffnvcodec >= 11.1.5.2 ffnvcodec < 12.0" "$ffnv_hdr_list" "" || \ check_pkg_config ffnvcodec "ffnvcodec >= 11.0.10.2 ffnvcodec < 11.1" "$ffnv_hdr_list" "" || \ check_pkg_config ffnvcodec "ffnvcodec >= 8.1.24.14 ffnvcodec < 8.2" "$ffnv_hdr_list" "" fi To me it looks like any ffnvcodec package of version in range between 8.1.24.14 and 12.1.14.0 will pass this check. чт, 14 сент. 2023 г. в 18:04, Timo Rothenpieler <t...@rothenpieler.org <mailto:t...@rothenpieler.org>>: On 14/09/2023 17:02, Roman Arzumanyan wrote: > Hi Timo, > > > The usual approach is to rely on the ffnvcodec version. > > Whenever you need a function from a specific version, bump the > versions in configure to the current version from git master and all the > respective old branches, since that will be the version of the next release. > > Sorry, but I don't understand what to do. Could you please give me a hand? > There's ffnvcodec.pc.in <http://ffnvcodec.pc.in> <http://ffnvcodec.pc.in <http://ffnvcodec.pc.in>> file where I can bump > the version from 12.1.14.0 to 12.1.14.1 Don't bump it. It gets bumped after every release. Just set the versions in configure to the current version from the various branches. > Then I see this check in ffmpeg/configure: > > if ! disabled ffnvcodec; then > > ffnv_hdr_list="ffnvcodec/nvEncodeAPI.h ffnvcodec/dynlink_cuda.h > ffnvcodec/dynlink_cuviddec.h ffnvcodec/dynlink_nvcuvid.h" > > check_pkg_config ffnvcodec "ffnvcodec >= 12.0.16.0" "$ffnv_hdr_list" "" || \ > > check_pkg_config ffnvcodec "ffnvcodec >= 11.1.5.2 ffnvcodec < 12.0" > "$ffnv_hdr_list" "" || \ > > check_pkg_config ffnvcodec "ffnvcodec >= 11.0.10.2 ffnvcodec < 11.1" > "$ffnv_hdr_list" "" || \ > > check_pkg_config ffnvcodec "ffnvcodec >= 8.1.24.14 ffnvcodec < 8.2" > "$ffnv_hdr_list" "" > > fi > > > Under the hood it adds cflags detected by pkg-config via > check_pkg_config function. But in the ffnvcodec.pc we don't export any > extra cflags. > > Do I have to add extra flags to ffnvcodec.pc.in <http://ffnvcodec.pc.in> > <http://ffnvcodec.pc.in <http://ffnvcodec.pc.in>>to define symbols containing the full > ffnvcodecpackage version? > > Like NVENC_API_MAJOR_VERSIONand NVENC_API_MINORversion but for the whole > ffnvcodec package? If configure depends on the latest versions, there is no need for further checks.-- --С уважением, Роман Арзуманян. Главный разработчик по направлению видео аналитики.
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
