On Thu, Jul 02, 2015 at 11:56:15PM -0300, Claudio Freire wrote:
> On Thu, Jul 2, 2015 at 3:13 PM, Rostislav Pehlivanov
> <atomnu...@gmail.com> wrote:
> > This commit modifies 02dbed6 to use band->active_lines to better gauge how 
> > much information is contained within a single band and thus allow the 
> > perceptual noise subsitution to more accurately determine which bands to 
> > code as noise. The spread[w+g] used before this patch behaved more like a 
> > low-pass filter for PNS band_types, which could mistakingly mark some low 
> > frequency bands as noise.
> >
> > Reviewed-by: Claudio Freire <klaussfre...@gmail.com>
> > ---
> >  libavcodec/aacpsy.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/aacpsy.c b/libavcodec/aacpsy.c
> > index 78232d4..b16f6b9 100644
> > --- a/libavcodec/aacpsy.c
> > +++ b/libavcodec/aacpsy.c
> > @@ -787,7 +787,7 @@ static void psy_3gpp_analyze_channel(FFPsyContext *ctx, 
> > int channel,
> >
> >              psy_band->threshold = band->thr;
> >              psy_band->energy    = band->energy;
> > -            psy_band->spread    = spread_en[w+g];
> > +            psy_band->spread    = band->active_lines * 2.0f / 
> > band_sizes[g];
> >          }
> >      }
> 
> 
> Can't say much since I proposed it myself, so... LGTM ;-)

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin

Attachment: signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to