Leo Izen: > On 8/1/23 14:59, Michael Niedermayer wrote: >> On Tue, Aug 01, 2023 at 09:30:54AM -0400, Leo Izen wrote: >>> This prevents code duplication in the source form by calling the parse >>> code that was moved to avcodec last commit. The code will be duplicated >>> in binary form for shared builds (it's not that large), but for source >>> code it will only exist in one location now. >>> >>> Signed-off-by: Leo Izen <leo.i...@gmail.com> >>> --- >>> libavformat/Makefile | 6 +- >>> libavformat/img2dec.c | 4 +- >>> libavformat/jpegxl_anim_dec.c | 132 +++-------- >>> libavformat/jpegxl_probe.c | 412 ---------------------------------- >>> libavformat/jpegxl_probe.h | 37 --- >>> libavformat/version.h | 2 +- >>> 6 files changed, 38 insertions(+), 555 deletions(-) >>> delete mode 100644 libavformat/jpegxl_probe.c >>> delete mode 100644 libavformat/jpegxl_probe.h >> >> breaks build with shared libs >> > > Interesting, I have jpegxl_parse.o in SHLIOBJS, but the actual file is > in libavcodec, and it's in libavcodec/Makefile's STLIOBJS declaration. > What else do I need to do in order to allow it to link into libavformat? >
It seems you forgot to add the lavf/jpegxl_parse.c stub. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
