Steven Liu: > Signed-off-by: Steven Liu <l...@chinaffmpeg.org> > --- > tests/fate/flvenc.mak | 7 ++++++- > tests/ref/fate/enhanced-flv-hevc | 8 ++++++++ > 2 files changed, 14 insertions(+), 1 deletion(-) > create mode 100644 tests/ref/fate/enhanced-flv-hevc > > diff --git a/tests/fate/flvenc.mak b/tests/fate/flvenc.mak > index 5032fface3..6b2fbe8c89 100644 > --- a/tests/fate/flvenc.mak > +++ b/tests/fate/flvenc.mak > @@ -1,5 +1,10 @@ > FATE_FLVENC_FFMPEG_FFPROBE-$(call TRANSCODE, FLV, FLV, RAWVIDEO_DECODER > SCALE_FILTER TESTSRC_FILTER LAVFI_INDEV) += fate-flv-add_keyframe_index > fate-flv-add_keyframe_index: CMD = transcode "lavfi -graph > testsrc=r=7:n=2:d=20" "foo" flv "-vf scale -c:v flv1 -dct int -g 7 -flvflags > add_keyframe_index" "-c copy -t 0.1" "-show_entries format_tags" > > +FATE_ENHANCED_FLVENC_FFMPEG-$(call REMUX, MOV, FLV_MUXER) += > fate-enhanced-flv-hevc > +fate-enhanced-flv-hevc: CMD = transcode mov $(TARGET_SAMPLES)/hevc/dv84.mov\ > + flv "-vcodec copy -map 0:v -frames 1" > + > FATE_FFMPEG_FFPROBE += $(FATE_FLVENC_FFMPEG_FFPROBE-yes) > -fate-flvenc: $(FATE_FLVENC_FFMPEG_FFPROBE-yes) > +FATE_SAMPLES_FFMPEG += $(FATE_ENHANCED_FLVENC_FFMPEG-yes) > +fate-flvenc: $(FATE_FLVENC_FFMPEG_FFPROBE-yes) > $(FATE_ENHANCED_FLVENC_FFMPEG-yes) > diff --git a/tests/ref/fate/enhanced-flv-hevc > b/tests/ref/fate/enhanced-flv-hevc > new file mode 100644 > index 0000000000..41eaefaf6e > --- /dev/null > +++ b/tests/ref/fate/enhanced-flv-hevc > @@ -0,0 +1,8 @@ > +afed0105d121688bad7dc94218256571 *tests/data/fate/enhanced-flv-hevc.flv > +64396 tests/data/fate/enhanced-flv-hevc.flv > +#tb 0: 1/30 > +#media_type 0: video > +#codec_id 0: rawvideo > +#dimensions 0: 1920x1080 > +#sar 0: 0/1 > +0, 0, 0, 1, 6220800, 0x1f259c93
Why are you restricting this to one frame? And why are you not copying the audio, too (this would test multiplexing)? After all, FLV supports AAC. Furthermore, you are copying the video when creating the intermediate FLV file, yet then you are decoding it at the next stage. This decoding would necessitate a dependency on the HEVC decoder (and maybe the parser as well as the extract_extradata bsf?). Alternatively, one can just use codec copy when reading the intermediate file as well (the latter is my preferred approach). The same remarks also apply to the other patches. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
