James Almer: > On 7/10/2023 10:10 PM, Andreas Rheinhardt wrote: >> This allows to avoid exposing AVCodecInternal to files that >> don't need it and only include internal.h for something else >> (like the avpriv functions which are of course included outside >> of libavcodec where AVCodecInternal should never be visible). >> >> Signed-off-by: Andreas Rheinhardt<andreas.rheinha...@outlook.com> >> --- >> libavcodec/aacdec_template.c | 2 +- >> libavcodec/amfenc.c | 2 +- >> libavcodec/amfenc_av1.c | 2 +- >> libavcodec/amfenc_h264.c | 2 +- >> libavcodec/amfenc_hevc.c | 2 +- >> libavcodec/aptxenc.c | 2 +- >> libavcodec/audiotoolboxenc.c | 2 +- >> libavcodec/av1dec.c | 2 +- >> libavcodec/avcodec.c | 3 +- >> libavcodec/avcodecinternal.h | 139 ++++++++++++++++++++++++++++++ > > I prefer avcodec_internal.h, to be in line with other similar internal > headers from modules with a public one. >
avcodec_internal.h is already taken by the header for the generic codec layer (i.e. the one that must not be included by individual codecs). > That aside it LGTM if checkheaders passes. The more files include only > what they need, the less likely to experience tree-wide recompilation > for changing a single header. True. Almost no files need both headers. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
