Le tiistaina 4. heinäkuuta 2023, 2.00.04 EEST Michael Niedermayer a écrit : > Suggested-by: Anton > > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > --- > doc/developer.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 0c2f2cd7d1..67f7f78e86 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -806,7 +806,7 @@ improves readability. > > @item > Consider adding a regression test for your code. All new modules > -should be covered by tests. That includes demuxers, muxers, decoders, > encoders +must be covered by tests. That includes demuxers, muxers, > decoders, encoders filters, bitstream filters, parsers. If its not possible > to do that, add an explanation why to your patchset, its ok to not test if > theres a reason.
The way that this paragraph is worded is self-contradictory. And while we are at it, the first (unmodified) sentence sorely lacks context, as it can only realistic apply to bug fixes, not just any code. Did you mean? > Consider adding a regression test for your BUG FIXES. All new modules > must be covered by AUTOMATED tests OR PROVIDE AN EXPLANATION WHY > DOING SO IS NOT POSSIBLE. That includes demuxers, muxers, decoders, > encoders, bitstream filters, parsers. -- 雷米‧德尼-库尔蒙 http://www.remlab.net/ _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
