On Sun, Jun 28, 2015 at 06:54:50PM +0200, Nicolas George wrote: > Le decadi 10 messidor, an CCXXIII, Michael Niedermayer a écrit : > > i understand that but taking the burden off the caller to print an > > error for memory allocation failures seemed overall to be the > > correct thing to do in this case > > > > if thats not wanted iam happy to drop this patch, it was just a > > suggestion as it seemed like the right thing to do in this case and > > alot simpler than the other way around > > Something I thought of after sending my first mail: > > Printing a specific warning for a small memory allocation failure is > useless. Small memory allocations do not fail under normal circumstances, > due to over commit. And even if the circumstances make they do fail, a whole > lot of them will fail, making the output fail at best, corrupted at work, > and in any case, cluttering the log with specific places of failure is not > helpful.
i had somehow implicitly assumed that the allocation would be big like somethig passing several megabyte long strings to av_set_dict(). Knowing about this when debuging could be usefull as its not the normal / sane thing that should happen, it might indicate that something is passed into av_set_dict() that shouldnt have been [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Democracy is the form of government in which you can choose your dictator
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
