On 05.06.2023 14:29, Roman Arzumanyan wrote:
Thanks for the review, Anton. Please find the updated patch attached.
BTW - what do you mean by "you should also forward the actual error code"?
Within the cuvid_handle_video_sequence() function in case of error,
function still returns 0 and sets internal context error, so I kept
behavior intact. Do I miss something?

applied with minor amendments.

Turned the if-statements around, we don't do them that way around in ffmpeg code. And switched the surfaces option to have a default of -1, to not rely on a magic value of 25. That could surprise users who happen to request 25 surfaces.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to